From: chrubis@suse.cz
To: Jan Stancek <jstancek@redhat.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] sendmsg02: fix compilation on kernel < 2.6.27
Date: Tue, 23 Apr 2013 12:32:03 +0200 [thread overview]
Message-ID: <20130423103202.GC28044@rei> (raw)
In-Reply-To: <8805528bb12e73785de99af72fa27fa90e535557.1366705953.git.jstancek@redhat.com>
Hi!
> testcases/kernel/syscalls/sendmsg/sendmsg02.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/sendmsg/sendmsg02.c b/testcases/kernel/syscalls/sendmsg/sendmsg02.c
> index 8f38f2c..c38d438 100644
> --- a/testcases/kernel/syscalls/sendmsg/sendmsg02.c
> +++ b/testcases/kernel/syscalls/sendmsg/sendmsg02.c
> @@ -88,7 +88,7 @@ static void client(int id, int pipefd[])
> mh.msg_iovlen = 1;
>
> do {
> - fd = socket(AF_UNIX, SOCK_DGRAM|SOCK_CLOEXEC, 0);
> + fd = socket(AF_UNIX, SOCK_DGRAM, 0);
> write(pipefd[1], &fd, 1);
> sendmsg(fd, &mh, MSG_NOSIGNAL);
> close(fd);
> @@ -109,7 +109,7 @@ static void server(int id, int pipefd[])
> snprintf(sa.sun_path, sizeof(sa.sun_path), "socket_test%d", id);
>
> do {
> - fd = socket(AF_UNIX, SOCK_DGRAM|SOCK_CLOEXEC|SOCK_NONBLOCK, 0);
> + fd = socket(AF_UNIX, SOCK_DGRAM, 0);
> unlink(sa.sun_path);
> bind(fd, (struct sockaddr *) &sa, sizeof(struct sockaddr_un));
> read(pipefd[0], &fd, 1);
This is fine.
And sorry that I haven't yet tested the testcase. I will hopefully
install OpenSUSE with selinux and test it soon.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2013-04-23 10:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 8:37 [LTP] [PATCH] sendmsg02: fix compilation on kernel < 2.6.27 Jan Stancek
2013-04-23 8:48 ` Wanlong Gao
2013-04-23 10:32 ` chrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130423103202.GC28044@rei \
--to=chrubis@suse.cz \
--cc=jstancek@redhat.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox