From: chrubis@suse.cz
To: Mike Frysinger <vapier@gentoo.org>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] remove linux_syscall_numbers.h from tree
Date: Thu, 25 Apr 2013 16:34:07 +0200 [thread overview]
Message-ID: <20130425143406.GA3084@rei.suse.cz> (raw)
In-Reply-To: <201304231342.02090.vapier@gentoo.org>
Hi!
> > > is keeping it in the tree a big deal ? i think it's pretty common for
> > > people to go into specific subdirs and run `make` and today, our
> > > subdirs don't declare a dependency on this file so it'll get
> > > automatically regenerated (nor do i think they should even bother).
> >
> > You need to regenerate the file after each change to the *.in files,
> > and that means that people will forget from time to time.
>
> so people aren't testing their commits ;)
Aparently they don't, I've reruned the script and the result is that git
diff shows 6125 lines of changes. And the last time the *.in files were
changed was 2010...
Which is another reason why we need proper solution.
What about we:
1) Commit the up to date linux_syscall_numbers.h
2) Add linux_syscall_numbers.h dependency on *.in
- that would regenerate the file on change, but only
from the top make and will catch the change
most of the time
Which would IMHO be good short term fix and figure out something better
later.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2013-04-25 14:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 13:53 [LTP] [PATCH] remove linux_syscall_numbers.h from tree Jan Stancek
2013-04-23 14:08 ` chrubis
2013-04-23 16:11 ` Mike Frysinger
2013-04-23 16:46 ` chrubis
[not found] ` <201304231342.02090.vapier@gentoo.org>
2013-04-23 18:08 ` chrubis
2013-04-25 14:34 ` chrubis [this message]
[not found] ` <201304251532.46436.vapier@gentoo.org>
2013-04-27 6:29 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130425143406.GA3084@rei.suse.cz \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox