Re: [LTP] [PATCH] remove linux_syscall_numbers.h from tree

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1.1: Type: Text/Plain, Size: 1813 bytes --]

On Thursday 25 April 2013 15:32:45 Mike Frysinger wrote:
> On Thursday 25 April 2013 10:34:07 chrubis@suse.cz wrote:
> > > > > is keeping it in the tree a big deal ?  i think it's pretty common
> > > > > for people to go into specific subdirs and run `make` and today,
> > > > > our subdirs don't declare a dependency on this file so it'll get
> > > > > automatically regenerated (nor do i think they should even
> > > > > bother).
> > > > 
> > > > You need to regenerate the file after each change to the *.in files,
> > > > and that means that people will forget from time to time.
> > > 
> > > so people aren't testing their commits ;)
> > 
> > Aparently they don't, I've reruned the script and the result is that git
> > diff shows 6125 lines of changes. And the last time the *.in files were
> > changed was 2010...
> > 
> > Which is another reason why we need proper solution.
> > 
> > What about we:
> >  1) Commit the up to date linux_syscall_numbers.h
> >  
> >  2) Add linux_syscall_numbers.h dependency on *.in
> >  
> >     - that would regenerate the file on change, but only
> >     
> >       from the top make and will catch the change
> >       most of the time
> > 
> > Which would IMHO be good short term fix and figure out something better
> > later.
> 
> it used to depend on the *.in files (i added it way back in 2008 with
> d885d4ae1037aa4aa8bb12f374776188867903d3 and
> 89ba1191d6c592e2f6d16824caa78b09fc714811).  looks like the overhaul in
> commit ef77253961f909f87e82e6d2b620e87af33e9665 broke that.  in the follow
> up 1bf1c2ad7b4e25c4f09479378314c9a4dd2b3a78, the commit message indicates
> it had meant to fix this, but it seems to not have.
> 
> so yes, let's add *.in and commit the regenerated file.

i've fixed & pushed this now
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 421 bytes --]

------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list