Re: [LTP] [PATCH] New core test of hardlinks and symlinks restrictions added in Linux 3.6. Disabled by default in Linux 3.7.

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1.1: Type: Text/Plain, Size: 949 bytes --]

On Monday 06 May 2013 05:41:18 Alexey Kodanev wrote:
> +#define BASE_DIR_NUM		(USERS_NUM+1)

spaces around that +

> +#define MAX_ENTITIES		(MAX_FILES_CREATED*BASE_DIR_NUM)

spaces around that *

> +static const char *file_postfix = ".hs";

for const strings you don't modify the pointer, use []:
	static const char file_postfix[] = ".hs";

> +option_t options[] = {

static, and probably const

> +static int cwd_offset;

you assign the return value of strlen() to this, so it should be size_t

> +static const char *hrdlink_proc_path	=
> +static const char *symlink_proc_path	= 

same thing wrt to * vs []

> +static void setup(int ac, char **av);

please use instead for argv:
	char *argv[]

> +int main(int ac, char **av)

same here

> +	if (tst_kvercmp(3, 7, 0) < 0) {
> +		tst_brkm(TCONF, &cleanup,
> +		"Test must be run with kernel 3.7 or newer");

unwrap, or indent the string one more level
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 383 bytes --]

------------------------------------------------------------------------------
Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET
Get 100% visibility into your production application - at no cost.
Code-level diagnostics for performance bottlenecks with <2% overhead
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap1

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list