Re: [LTP] [PATCH] Makefile: Disable parallel build for $(CRITICAL_MAKEFILES)

[chrubis@suse.cz]

Hi!
> > > I got a an idea how to fix this in portable fashion. The key is the order
> > > of filenames the make looks for.
> > > 
> > > The gnu make tries GNUmakefile first, then makefile or Makefile.
> > > 
> > > So if we create GNUmakefile, which would include the Makefile and adds
> > > the .NOTPARALLEL: target it should work both with both GNU make and any
> > > other POSIX conforming make out there.
> > 
> > I think your idea is good. 
> > But I think that the code to distinguish GNU make and other POSIX will makes
> > the Makefile to be more complex.
> > I do not wish to complicate the Makefile more than is necessary.
> > How about using '-j1' without '.NOTPARALLEL:' option as follows.
> 
> Again the same problem as previously. The POSIX specification does not
> require the -j option to exist as the standard does not take parallel
> build into the account at all. And for the Open Posix part of LTP we
> need to stick to the POSIX.
> 
> And looking at the POSIX spec again, the POSIX make does not even
> support including files. So the only way how to fix this is to copy the
> top level Makefile to GNUmakefile and add the line. :(

I've looked into the openposix Makefile and it allready contains non
conforming '-j1' options. I will have closer look at the build scripts
and Makefiles.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
How ServiceNow helps IT people transform IT departments:
1. A cloud service to automate IT design, transition and operations
2. Dashboards that offer high-level views of enterprise services
3. A single system of record for all IT processes
http://p.sf.net/sfu/servicenow-d2d-j
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list