Re: [LTP] [PATCH] configure: add configure checks to compile kernel modules

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1.1: Type: Text/Plain, Size: 723 bytes --]

On Tuesday 11 June 2013 05:34:57 alexey.kodanev@oracle.com wrote:
> On 06/11/2013 05:31 AM, Mike Frysinger wrote:
> > defaulting like this won't work.  you need to check $cross_compiling is
> > set to yes in order to default to `uname -r`.
> > 
> > seems like it'd be simpler to just do:
> > 	AC_ARG_WITH([linux-version], [AC_HELP_STRING(...)],,
> > 		AS_IF([test "$cross_compiling" != no],
> > 			[with_linux_version=`uname -r`]))
> > 	LINUX_VERSION=$with_linux_version
> > 	AC_SUBST(LINUX_VERSION)
> 
> May be defaulting it to `uname -r` when $cross_compiling is set to no?

yeah, i inverted the check here (i didn't test any of the code ... just typed 
it into the e-mail).  but you get the idea.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 184 bytes --]

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list