From: chrubis@suse.cz
To: Caspar Zhang <caspar@casparzhang.com>
Cc: LTP list <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH] mmap/mmap12.c: new case to test MAP_POPULATE of mmap
Date: Wed, 19 Jun 2013 12:59:14 +0200 [thread overview]
Message-ID: <20130619105914.GA24520@rei> (raw)
In-Reply-To: <51C18279.7000607@casparzhang.com>
Hi!
> > + ret = sysinfo(&info);
> > + if (ret != 0)
> > + tst_brkm(TFAIL, cleanup, "sysinfo failed");
> > + freeram_after =
> > + (unsigned long long)info.freeram *
> > + (unsigned long long)info.mem_unit;
>
> man sysinfo:
>
> This function is Linux-specific, and should not be used in
> programs intended to be portable.
>
> We're expecting all LTP tests are POSIX-compatible, sysinfo is
> Linux-specific, would it better to read the info from /proc/meminfo
> directly?
That is true for the Open Posix Testsuite, but this test is added under
testcases/kernel/ for which it is fine.
Note also that MAP_POPULATE is itself Linux specific ;).
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2013-06-19 10:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 6:52 [LTP] [PATCH] mmap/mmap12.c: new case to test MAP_POPULATE of mmap DAN LI
2013-06-19 10:05 ` Caspar Zhang
2013-06-19 10:59 ` chrubis [this message]
2013-06-19 11:21 ` chrubis
2013-06-19 12:00 ` Jan Stancek
2013-06-20 7:11 ` DAN LI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130619105914.GA24520@rei \
--to=chrubis@suse.cz \
--cc=caspar@casparzhang.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox