From: chrubis@suse.cz
To: Mike Frysinger <vapier@gentoo.org>
Cc: Alexey Kodanev <alexey.kodanev@oracle.com>,
ltp-list@lists.sourceforge.net, vasily.isaenko@oracle.com
Subject: Re: [LTP] [PATCH] tst_module: create new library functions for kernel modules
Date: Mon, 24 Jun 2013 13:56:35 +0200 [thread overview]
Message-ID: <20130624115635.GB1638@rei> (raw)
In-Reply-To: <201306221415.17130.vapier@gentoo.org>
Hi!
> > +/* declared in tst_tmpdir.c */
> > +const char *tst_get_startwd(void);
>
> use a proper header instead. extern func decls only leads to bit rot and hard
> to debug crashes.
This is internal only API for the LTP lib that does not have a proper
header (I was too lazy to create a header for the function that is used
only once). I can fix that if desired.
> use fork()+execvp() instead. there's no need to normalize to a string and
> then run through a shell.
>
> wonder if we should add a util func for this ...
That sounds like good idea.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2013-06-24 11:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 11:54 [LTP] [PATCH] tst_module: create new library functions for kernel modules Alexey Kodanev
2013-06-22 18:15 ` Mike Frysinger
2013-06-24 10:01 ` alexey.kodanev
2013-06-24 15:29 ` Mike Frysinger
2013-06-24 11:56 ` chrubis [this message]
[not found] ` <201306241136.07004.vapier@gentoo.org>
2013-06-24 15:43 ` chrubis
2013-06-24 16:02 ` chrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130624115635.GB1638@rei \
--to=chrubis@suse.cz \
--cc=alexey.kodanev@oracle.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=vapier@gentoo.org \
--cc=vasily.isaenko@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox