Re: [LTP] [PATCH v2] mmap/mmap13.c: new case to test SIGBUS error of mmap

Re: [LTP] [PATCH v2] mmap/mmap13.c: new case to test SIGBUS error of mmap

[chrubis]

Hi!
> Test SIGBUS error by accessing to a portion of the buffer that does not
> correspond to the file.
> 
> Signed-off-by: DAN LI <li.dan@cn.fujitsu.com>
> ---
>  runtest/syscalls                        |   1 +
>  testcases/kernel/syscalls/mmap/mmap13.c | 152 ++++++++++++++++++++++++++++++++
>  2 files changed, 153 insertions(+)
>  create mode 100644 testcases/kernel/syscalls/mmap/mmap13.c

...

> +
> +		addr = mmap(0, page_sz * 2, PROT_READ | PROT_WRITE,
> +			    MAP_FILE | MAP_SHARED, fildes, 0);

The first parameter should really have been NULL, pushed with that
change, thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH v2] mmap/mmap13.c: new case to test SIGBUS error of mmap

[chrubis]

Hi!
> > Test SIGBUS error by accessing to a portion of the buffer that does not
> > correspond to the file.
> > 
> > Signed-off-by: DAN LI <li.dan@cn.fujitsu.com>
> 
> Reviewed-by: Jan Stancek <jstancek@redhat.com>
> 
> v2 looks good to me. As for others, ../.gitignore is missing "mmap13",
> but I think comitter can add that.
> 

I've commited this one allready (along with another patch to add it to
gitignore (as I noticed this later)).

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list