From: chrubis@suse.cz
To: DAN LI <li.dan@cn.fujitsu.com>
Cc: LTP list <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH v2] mmap/mmap12.c: new case to test MAP_POPULATE of mmap
Date: Thu, 27 Jun 2013 14:35:00 +0200 [thread overview]
Message-ID: <20130627123500.GC5384@rei> (raw)
In-Reply-To: <51CA495D.9090500@cn.fujitsu.com>
> >> + while (num_pages > 0) {
> >> + ret = read(pm, &pagemap, sizeof(unsigned long long));
> >> + if (ret < 0)
> >> + tst_brkm(TFAIL | TERRNO, NULL, "Read pagemap failed");
> >> + /*
> >> + * Check if the page is present.
> >> + */
> >> + if (!(pagemap & (1ULL<<63))) {
> >> + close(pm);
> >> + fclose(maps);
> >> + return 1;
> >
> > I would perpahs be more verbose here and go over all of the pages and
> > list these that are not mapped, but that is a minor nitpick.
> >
>
> You mean listing every page which is not present?
Yes please, nothing fancy just short message with address of the page
and its ordering number in the mapping printed using tst_resm with
TINFO.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2013-06-27 12:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <51C95F37.3000409@cn.fujitsu.com>
2013-06-25 14:17 ` [LTP] [PATCH v2] mmap/mmap12.c: new case to test MAP_POPULATE of mmap chrubis
[not found] ` <51CA495D.9090500@cn.fujitsu.com>
2013-06-27 12:35 ` chrubis [this message]
[not found] ` <804366117.1964429.1372157275604.JavaMail.root@redhat.com>
2013-06-26 1:36 ` DAN LI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130627123500.GC5384@rei \
--to=chrubis@suse.cz \
--cc=li.dan@cn.fujitsu.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox