From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1UsBWr-0003Pc-Uh for ltp-list@lists.sourceforge.net; Thu, 27 Jun 2013 12:42:26 +0000 Date: Thu, 27 Jun 2013 14:43:54 +0200 From: chrubis@suse.cz Message-ID: <20130627124354.GD5384@rei> References: <1372322290-21498-1-git-send-email-gaowanlong@cn.fujitsu.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1372322290-21498-1-git-send-email-gaowanlong@cn.fujitsu.com> Subject: Re: [LTP] [PATCH] aio02: remove test for aio_fsync() and aio_fdsync() List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: Wanlong Gao Cc: Garrett Cooper , LTP , Mike Frysinger Hi! > Linux filesystems doesn't support aio_fsync() and aio_fdsync() > operations, so just remove test for these two. > > Signed-off-by: Wanlong Gao The patch is OK but the commit description is a bit misleading. Do not mix the POSIX aio_* which is implemented in userspace in libc and Linux kernel io_* interface that implements AIO in linux kernel. I would use the IO_* constants in the commit message instead of the aio_* functions which seems to misleadingly suggest the libc implementation. -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list