From: Mike Frysinger <vapier@gentoo.org>
To: ltp-list@lists.sourceforge.net
Cc: Alexey Kodanev <alexey.kodanev@oracle.com>, vasily.isaenko@oracle.com
Subject: Re: [LTP] [PATCH v4] lib: tst_module: add library functions for kernel modules
Date: Fri, 28 Jun 2013 01:35:44 -0400 [thread overview]
Message-ID: <201306280135.45066.vapier@gentoo.org> (raw)
In-Reply-To: <1372345762-5425-1-git-send-email-alexey.kodanev@oracle.com>
[-- Attachment #1.1: Type: Text/Plain, Size: 352 bytes --]
On Thursday 27 June 2013 11:09:22 Alexey Kodanev wrote:
\> +void tst_module_load(void (cleanup_fn)(void),
> + const char *mod_name, char *const argv[])
> +{
> + char *mod_path = NULL;
> + tst_module_exists(cleanup_fn, mod_name, &mod_path);
> +
> + static int offset = 2; /* command name & module path */
why static ? i would use const instead.
-mike
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 184 bytes --]
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
[-- Attachment #3: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2013-06-28 5:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 15:09 [LTP] [PATCH v4] lib: tst_module: add library functions for kernel modules Alexey Kodanev
2013-06-27 15:27 ` chrubis
2013-06-28 3:16 ` Caspar Zhang
2013-06-28 3:17 ` Wanlong Gao
2013-06-28 5:35 ` Mike Frysinger [this message]
2013-07-01 8:30 ` alexey.kodanev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201306280135.45066.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=alexey.kodanev@oracle.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=vasily.isaenko@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox