Re: [LTP] [PATCH v6] fw_load: new test of device firmware loading

[chrubis@suse.cz]

Hi!
> This test checks the device firmware loading. Since Linux 3.7 it can be loaded
> directly (by-pass udev). The test consists of the two parts: userspace and
> kernelspace.
> 
> Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>

This version looks good to me.

But there is one catch there, as we divided the module load function
into the load_module and run_cmd functions the testcase will end up with
TBROK rather than with TCONF when the kernel module couldn't be loaded
due to version mismatch and I would preffer the TCONF in this case.

But that does not block the inclusion of this testcase (and the
configure patch that needs to be applied beforhand) and if we agree that
TCONF is better we can fix the module_load later. One solution that
seems easy enough is to make the run_cmd() return the wait status (as
system() does).

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list