Re: [LTP] [PATCH v6] fw_load: new test of device firmware loading

[chrubis@suse.cz]

Hi!
> >> >  +++ b/testcases/kernel/firmware/fw_load_kernel/Makefile
> >> >
> >> >  +MAKE_TARGETS	:= ltp_fw_load.ko
> >> >  +ltp_fw_load.ko: ltp_fw_load.c
> >> >  +	-$(MAKE) -C $(LINUX_DIR) M=$(abs_srcdir)
> >> >  +	-mv ltp_fw_load.ko ltp_fw_load.ko~
> >> >  +	-$(MAKE) -C $(LINUX_DIR) M=$(abs_srcdir) clean
> >> >  +	-mv ltp_fw_load.ko~ ltp_fw_load.ko
> > what's with ignoring the exit status of all these ?  and why clean when you're
> > done ?  doesn't seem like you'd want to do either of these.
> >
> Ignoring the exit status, allow to proceed with the LTP build, despite 
> of any error during the module's build. Then, user-space test will 
> return TCONF, if it doesn't find the module.

This is done so that LTP is forward compatible with kernel internal API
changes. The test tries to load the module and returns TCONF if module
was not found (i.e. wasn't build either due to kernel-devel missing or
module build failure).

> There are a lot of files that left after module's build and If I don't 
> clean there, I have to manually add files to the clean target and 
> perhaps, even more.

Making make clean work would be better, but I'm not sure how to make
that work, the kernel build leaves various files there and I'm not sure
if these have stable names, but we can do some effort to clean up all
the *.cmd.o and maybe some of the rest of them.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list