Re: [LTP] [PATCH 1/2 v3] xinetd/xinetd_tests.sh: cleanup tabs

[Hangbin Liu <liuhangbin@gmail.com>]

On Thu, Jul 11, 2013 at 11:55:21AM +0800, Caspar Zhang wrote:
> On 07/11/2013 11:52 AM, Wanlong Gao wrote:
> >On 07/11/2013 11:35 AM, Hangbin Liu wrote:
> >>On Thu, Jul 11, 2013 at 01:28:34AM +0800, Caspar Zhang wrote:
> >>>On 07/10/2013 07:03 PM, Xie Lingyun wrote:
> >>>>+defaults
> >>>>+{
> >>>>+instances      = 25
> >>>>+log_type       = FILE /var/log/servicelog
> >>>>+log_on_success = HOST PID
> >>>>+log_on_failure = HOST RECORD
> >>>>+disabled       = telnet
> >>>>+}
> >>>
> >>>Generally looks good except here.
> >>>
> >>>better give a 4-space indentation inside the braces.
> >>>
> >>
> >>1-tab or 4-space, I always be confuse which should we use. Even a tab should
> >>be 4 characters or 8 characters also have dispute. But the kernel coding style
> >>said Tabs are 8 characters, and thus indentations are also 8 characters.
> >>
> >>So, should we also use this style in shell scripts? Because I'm tired
> >>changing my vim config for each project.
> >
> >We are just following kernel coding style in LTP.
> 
> We are talking about shell coding style right? IIRC kernel coding
> style is just for C.

That's what I'm confused about, what coding style should we use for shell?
Following the kernel C style or find another one?

-- 

Thanks & Best Regards
Hangbin Liu <liuhangbin@gmail.com>

------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list