Re: [LTP] [PATCH V3] lib: add tst_kvercmp2 to compare specific vendor extra kernel versions

[chrubis@suse.cz]

Hi!
> > > +static int tst_kexvcmp(char *tst_exv, char *cur_ver)
> > > +{
> > > +	int c1 = 0, c2 = 0, t1 = 0, t2 = 0;
> > > +	int ret;
> > > +
> > > +	sscanf(cur_ver, "%*d.%*d.%*d-%d.%d", &c1, &c2);
> > > +	sscanf(tst_exv, "%d.%d", &t1, &t2);
> > > +	if ((ret = c1 - t1))
> > 
> > not sure if the brackets are duplicated...
> 
> What caught my (and checkpatch's) eye is that these are assignments in if condition,
> but I'm not sure how strictly we take checkpatch output.

Assignment inside of condition is generally considered as a tricky
statement which is why checkpatch gives a warning.

I'm personally not against it as long as it's simple statement like this
but if other people here disagree I'm fine with treating it as a wrong
thing to do.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list