From: chrubis@suse.cz
To: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Cc: LTP <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH V2 1/2] lib: let tst_kvercmp2() contains major kernel version
Date: Tue, 16 Jul 2013 13:43:47 +0200 [thread overview]
Message-ID: <20130716114347.GB20826@rei> (raw)
In-Reply-To: <1373966367-18078-1-git-send-email-gaowanlong@cn.fujitsu.com>
Hi!
> +int tst_kvercmp2(struct tst_kern_exv *vers);
I would prefer if the tst_kvercmp2() would contain version numbers for
vanilla kernel too so that we can do just:
static struct tst_kern_exv kvers[] = {
{ "RHEL5", "2.6.18-132" },
{ NULL, NULL },
};
if (tst_kvercmp2(2, 6, 25, kvers) >= 0)
...
But that is minor.
And what about we add an TINFO message about which distro was detected?
Something like:
if (!strcmp(vers[i].dist_name, cur_dist_name)) {
tst_resm(TINFO, "Detected %s using kernel version %s",
vers[i].dist_name, vers[i].extra_ver);
...
The rest of the code looks good.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next parent reply other threads:[~2013-07-16 11:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1373966367-18078-1-git-send-email-gaowanlong@cn.fujitsu.com>
2013-07-16 11:43 ` chrubis [this message]
[not found] ` <51E540CC.3070406@cn.fujitsu.com>
2013-07-16 13:24 ` [LTP] [PATCH V2 1/2] lib: let tst_kvercmp2() contains major kernel version chrubis
[not found] ` <51E554C8.4070307@cn.fujitsu.com>
2013-07-16 15:52 ` chrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130716114347.GB20826@rei \
--to=chrubis@suse.cz \
--cc=gaowanlong@cn.fujitsu.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox