Re: [LTP] [PATCH] tst_run_cmd: const correctness

[chrubis@suse.cz]

Hi!
>  void tst_run_cmd_fds(void (cleanup_fn)(void),
> -			char *const argv[],
> +			const char *const argv[],
>  			int stdout_fd,
>  			int stderr_fd);
>  
> @@ -236,7 +236,7 @@ void tst_run_cmd_fds(void (cleanup_fn)(void),
>   * not needed.
>   */
>  void tst_run_cmd(void (cleanup_fn)(void),
> -		char *const argv[],
> +		const char *const argv[],
>  		const char *stdout_path,
>  		const char *stderr_path);

Gosh, that fixed the warning in the test but I've overlooked that
execvp() takes char *const argv[] argument so it introduced warning in
the lib. Now I wonder why execvp() has such strange parameter type...

I'm trying to figure out how to fix it 'right' but it gets unnecessary
complicated. I guess that we can fix this patch by casting the array in
the lib before it gets to execvp().

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead. 
Download for free and get started troubleshooting in minutes. 
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list