From: chrubis@suse.cz
To: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
Cc: vasily.isaenko@oracle.com, ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] rt_sigaction: headers are included in a uniform way
Date: Tue, 13 Aug 2013 18:11:22 +0200 [thread overview]
Message-ID: <20130813161122.GA29678@rei> (raw)
In-Reply-To: <1376369417-13511-1-git-send-email-stanislav.kholmanskikh@oracle.com>
Hi!
> diff --git a/testcases/kernel/syscalls/rt_sigaction/rt_sigaction02.c b/testcases/kernel/syscalls/rt_sigaction/rt_sigaction02.c
> index 5beabef..0e2915e 100644
> --- a/testcases/kernel/syscalls/rt_sigaction/rt_sigaction02.c
> +++ b/testcases/kernel/syscalls/rt_sigaction/rt_sigaction02.c
> @@ -46,28 +46,11 @@
> #include <sys/syscall.h>
> #include <string.h>
>
> +#define LTP_RT_SIG_TEST
As far as I see these two testcases does not use the interface exposed
after this is defined. If this is so there is no need to define it here.
> diff --git a/testcases/kernel/syscalls/rt_sigaction/rt_sigaction03.c b/testcases/kernel/syscalls/rt_sigaction/rt_sigaction03.c
> index 646c37d..b160f2b 100644
> --- a/testcases/kernel/syscalls/rt_sigaction/rt_sigaction03.c
> +++ b/testcases/kernel/syscalls/rt_sigaction/rt_sigaction03.c
> @@ -46,9 +46,11 @@
> #include <sys/syscall.h>
> #include <string.h>
>
> +#define LTP_RT_SIG_TEST
Here as well.
Otherwise it looks ok.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead.
Download for free and get started troubleshooting in minutes.
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2013-08-13 16:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 4:50 [LTP] [PATCH] rt_sigaction: headers are included in a uniform way Stanislav Kholmanskikh
2013-08-13 16:11 ` chrubis [this message]
2013-08-14 7:31 ` [LTP] [PATCH V2] " Stanislav Kholmanskikh
2013-08-14 9:34 ` chrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130813161122.GA29678@rei \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=stanislav.kholmanskikh@oracle.com \
--cc=vasily.isaenko@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox