Re: [LTP] [PATCH] rt_sigaction: headers are included in a uniform way

chrubis
2013-08-13T16:11:25Z

Hi!
> diff --git a/testcases/kernel/syscalls/rt_sigaction/rt_sigaction02.c b/testcases/kernel/syscalls/rt_sigaction/rt_sigaction02.c
> index 5beabef..0e2915e 100644
> --- a/testcases/kernel/syscalls/rt_sigaction/rt_sigaction02.c
> +++ b/testcases/kernel/syscalls/rt_sigaction/rt_sigaction02.c
> @@ -46,28 +46,11 @@
> #include <sys/syscall.h>
> #include <string.h>
>
> +#define LTP_RT_SIG_TEST

As far as I see these two testcases does not use the interface exposed
after this is defined. If this is so there is no need to define it here.

> diff --git a/testcases/kernel/syscalls/rt_sigaction/rt_sigaction03.c b/testcases/kernel/syscalls/rt_sigaction/rt_sigaction03.c
> index 646c37d..b160f2b 100644
> --- a/testcases/kernel/syscalls/rt_sigaction/rt_sigaction03.c
> +++ b/testcases/kernel/syscalls/rt_sigaction/rt_sigaction03.c
> @@ -46,9 +46,11 @@
> #include <sys/syscall.h>
> #include <string.h>
>
> +#define LTP_RT_SIG_TEST

Here as well.

Otherwise it looks ok.

--
Cyril Hrubis
chrubis@suse.cz