Re: [LTP] [PATCH] syscalls/migrate_pages: fix nodemask memory allocation

[chrubis@suse.cz]

Hi!
> ---
>  .../syscalls/migrate_pages/migrate_pages01.c       |    5 ++++-
>  .../syscalls/migrate_pages/migrate_pages02.c       |    5 ++++-
>  2 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/testcases/kernel/syscalls/migrate_pages/migrate_pages01.c b/testcases/kernel/syscalls/migrate_pages/migrate_pages01.c
> index c23e8b0..9981c0c 100644
> --- a/testcases/kernel/syscalls/migrate_pages/migrate_pages01.c
> +++ b/testcases/kernel/syscalls/migrate_pages/migrate_pages01.c
> @@ -248,7 +248,10 @@ static void setup(void)
>  			 ret);
>  
>  	sane_max_node = get_max_node();
> -	sane_nodemask_size = sane_max_node / 8 + 1;
> +	sane_nodemask_size = sane_max_node / (sizeof(unsigned long)*8);
> +	sane_nodemask_size += sane_max_node % (sizeof(unsigned long)*8) == 0 ?
> +				0 : 1;
> +	sane_nodemask_size *= sizeof(unsigned long);

Do we really need to round it sizeof(unsigned long) or is creating large
enough array sufficient?

What about:

sane_max_node / 8 + sizeof(unsinged long);

Which should yield size that is at least as large as the size we need.

Also I would create a macro to do that NODEMASK_SIZE() and put it into
migrate_pages_common.h header.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Introducing Performance Central, a new site from SourceForge and 
AppDynamics. Performance Central is your source for news, insights, 
analysis and resources for efficient Application Performance Management. 
Visit us today!
http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list