From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1VC4XS-0007C3-M3 for ltp-list@lists.sourceforge.net; Wed, 21 Aug 2013 09:17:14 +0000 Date: Wed, 21 Aug 2013 11:17:13 +0200 From: chrubis@suse.cz Message-ID: <20130821091712.GA3558@rei> References: <1376908164-10045-1-git-send-email-stanislav.kholmanskikh@oracle.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1376908164-10045-1-git-send-email-stanislav.kholmanskikh@oracle.com> Subject: Re: [LTP] [PATCH] syscalls/migrate_pages: fix nodemask memory allocation List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: Stanislav Kholmanskikh Cc: vasily.isaenko@oracle.com, ltp-list@lists.sourceforge.net Hi! > --- > .../syscalls/migrate_pages/migrate_pages01.c | 5 ++++- > .../syscalls/migrate_pages/migrate_pages02.c | 5 ++++- > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/testcases/kernel/syscalls/migrate_pages/migrate_pages01.c b/testcases/kernel/syscalls/migrate_pages/migrate_pages01.c > index c23e8b0..9981c0c 100644 > --- a/testcases/kernel/syscalls/migrate_pages/migrate_pages01.c > +++ b/testcases/kernel/syscalls/migrate_pages/migrate_pages01.c > @@ -248,7 +248,10 @@ static void setup(void) > ret); > > sane_max_node = get_max_node(); > - sane_nodemask_size = sane_max_node / 8 + 1; > + sane_nodemask_size = sane_max_node / (sizeof(unsigned long)*8); > + sane_nodemask_size += sane_max_node % (sizeof(unsigned long)*8) == 0 ? > + 0 : 1; > + sane_nodemask_size *= sizeof(unsigned long); Do we really need to round it sizeof(unsigned long) or is creating large enough array sufficient? What about: sane_max_node / 8 + sizeof(unsinged long); Which should yield size that is at least as large as the size we need. Also I would create a macro to do that NODEMASK_SIZE() and put it into migrate_pages_common.h header. -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list