From: chrubis@suse.cz
To: DAN LI <li.dan@cn.fujitsu.com>
Cc: LTP list <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH 1/2] Add support for xfs quota tests
Date: Thu, 22 Aug 2013 11:22:09 +0200 [thread overview]
Message-ID: <20130822092208.GA12621@rei.ASUS> (raw)
In-Reply-To: <52158F02.9000105@cn.fujitsu.com>
Hi!
> > I've just pushed a patchset that implements this functionality.
> > (It has been finished previous week but I hold it util I had time to
> > test it properly)
> >
> > Everybody please test this change and report any problems.
>
> I got a little problem when using this function.
>
>
> Defaultly, the command mkfs.xfs will not write to the device if it suspects that
> there is a filesystem or partition table on the device already.
> So, i need to add the "-f" option for mkfs.xfs to force the formatting.
>
> But, the command "mkfs dev -t xfs -f" does not work as expected.
> Could you please change it to "mkfs -t fs_type fs_opts dev" in tst_mkfs()?
I've created and pushed a patch that shuffles the params so that they
are in right order.
And I'm thinking if it actually would be better to add the -f parameter
in the tst_mkfs() if fs_type is xfs. As just now if you want to run any
of the tests that operate on a filesystem with xfs it fails in the same
way.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Introducing Performance Central, a new site from SourceForge and
AppDynamics. Performance Central is your source for news, insights,
analysis and resources for efficient Application Performance Management.
Visit us today!
http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2013-08-22 9:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 5:10 [LTP] [PATCH 1/2] Add support for xfs quota tests DAN LI
2013-07-17 5:17 ` [LTP] [PATCH 2/2] quotactl/quotactl02.c: create a case to test basic flags of quotactl(2) DAN LI
2013-07-17 12:22 ` chrubis
2013-07-17 12:05 ` [LTP] [PATCH 1/2] Add support for xfs quota tests chrubis
[not found] ` <51FA290E.1040804@cn.fujitsu.com>
2013-08-01 11:41 ` chrubis
2013-08-12 11:53 ` chrubis
[not found] ` <52158F02.9000105@cn.fujitsu.com>
2013-08-22 9:22 ` chrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130822092208.GA12621@rei.ASUS \
--to=chrubis@suse.cz \
--cc=li.dan@cn.fujitsu.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox