Re: [LTP] [PATCH] syscalls/setgroups: fix implicit SETGROUPS parameter casting

chrubis
2013-08-26T14:16:07Z

Hi!
> But we can't rely on the fact that group ids of a user invoking the
> testcases are fit into __old_gid_t.
>
> And the purpose of current GETGROUPS definition is to handle such cases.
>
> A situation may happen where root user is a member of a group with a
> _big_ group id.
>
> So I'm not 100% sure about fixing getgroups part of the same header.
>
> Or did I miss something?

What I mean is that we should check if the compatibility getgroups
syscall exists and if not abort the test (as the setgroups will do).
Because the 32 bit getgroups syscall is tested with the tests without
the TST_USE_COMPAT16_SYSCALL.

--
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Introducing Performance Central, a new site from SourceForge and
AppDynamics. Performance Central is your source for news, insights,
analysis and resources for efficient Application Performance Management.
Visit us today!