From: chrubis@suse.cz
To: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
Cc: vasily.isaenko@oracle.com, ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] syscalls/setgroups: fix implicit SETGROUPS parameter casting
Date: Mon, 26 Aug 2013 16:16:12 +0200 [thread overview]
Message-ID: <20130826141612.GB3344@rei> (raw)
In-Reply-To: <521B4D82.2060007@oracle.com>
Hi!
> But we can't rely on the fact that group ids of a user invoking the
> testcases are fit into __old_gid_t.
>
> And the purpose of current GETGROUPS definition is to handle such cases.
>
> A situation may happen where root user is a member of a group with a
> _big_ group id.
>
> So I'm not 100% sure about fixing getgroups part of the same header.
>
> Or did I miss something?
What I mean is that we should check if the compatibility getgroups
syscall exists and if not abort the test (as the setgroups will do).
Because the 32 bit getgroups syscall is tested with the tests without
the TST_USE_COMPAT16_SYSCALL.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Introducing Performance Central, a new site from SourceForge and
AppDynamics. Performance Central is your source for news, insights,
analysis and resources for efficient Application Performance Management.
Visit us today!
http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2013-08-26 14:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 7:10 [LTP] [PATCH] syscalls/setgroups: fix implicit SETGROUPS parameter casting Stanislav Kholmanskikh
2013-08-22 13:13 ` chrubis
[not found] ` <52174875.9030606@oracle.com>
2013-08-23 11:39 ` chrubis
[not found] ` <521B331D.7050902@oracle.com>
2013-08-26 11:30 ` chrubis
[not found] ` <521B4D82.2060007@oracle.com>
2013-08-26 14:16 ` chrubis [this message]
[not found] ` <521B6875.8010202@oracle.com>
2013-08-27 9:35 ` [LTP] [PATCH V2 1/2] syscalls/setgroups: fix 16-bit versions of the testcases Stanislav Kholmanskikh
2013-08-27 9:35 ` [LTP] [PATCH V2 2/2] syscalls/getgroups: added checks for 16-bit getgroups() syscall Stanislav Kholmanskikh
2013-08-27 12:16 ` chrubis
[not found] ` <521D9C44.8090607@oracle.com>
2013-08-28 9:55 ` chrubis
[not found] ` <1377782535-15955-3-git-send-email-stanislav.kholmanskikh@oracle.com>
2013-09-02 15:23 ` [LTP] [PATCH V3 2/3] fixes for 16-bit syscalls testcases chrubis
[not found] ` <52259811.3000604@oracle.com>
2013-09-03 10:11 ` chrubis
[not found] ` <1378215677-14258-1-git-send-email-stanislav.kholmanskikh@oracle.com>
2013-09-04 13:37 ` [LTP] [PATCH V3.1 2/2] " chrubis
[not found] ` <1378364509-20971-1-git-send-email-stanislav.kholmanskikh@oracle.com>
2013-09-05 11:07 ` [LTP] [PATCH V4] 16-bit syscalls fixes chrubis
2013-09-09 12:07 ` chrubis
[not found] ` <1377782535-15955-4-git-send-email-stanislav.kholmanskikh@oracle.com>
2013-09-02 15:28 ` [LTP] [PATCH V3 3/3] syscalls/getgroups: added checks for 16-bit getgroups() syscall chrubis
[not found] ` <1377782535-15955-2-git-send-email-stanislav.kholmanskikh@oracle.com>
2013-09-02 15:59 ` [LTP] [PATCH V3 1/3] syscalls/utils/compat_16.mk: fix build dependencies chrubis
[not found] ` <52257D67.5020900@oracle.com>
2013-09-03 11:06 ` chrubis
2013-08-27 11:22 ` [LTP] [PATCH] syscalls/setgroups: fix implicit SETGROUPS parameter casting chrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130826141612.GB3344@rei \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=stanislav.kholmanskikh@oracle.com \
--cc=vasily.isaenko@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox