Re: [LTP] [PATCH 2/2 v2] quotactl/quotactl02.c: create a case to test basic flags of quotactl(2)

[chrubis@suse.cz]

Hi!
> > You don't need to have function to statically initialize a structure, I
> > would just initialized it statically and passed right pointer to the
> > testcase addr.
> 
> I am afraid I don't catch your meaning.
> 
> This function setup_setqlim set up the structure "dquota" for the setqlim test,
> and crucially, the structure "dquota" is used by other tests, so its value will
> change after statically initializing.
> 

You can define as many structures as you want, one for this particular
test and one for the rest of the testcases for example, does the syscall
modify the structure?

> > 
> >> +	tst_mkfs(NULL, dev, "xfs", "-f");
> > 
> > I still think that the '-f' should go to the library instead. Or we can
> > zero start of the device (where the filesystem superblock and signatures
> > are, which should be first few bytes) before we call the mkfs.
> 
> I vote to "add the -f parameter in the tst_mkfs() if fs_type is xfs"
> 

Ok, I will fix that.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list