From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1VEcCX-00054n-Me for ltp-list@lists.sourceforge.net; Wed, 28 Aug 2013 09:38:09 +0000 Date: Wed, 28 Aug 2013 11:38:10 +0200 From: chrubis@suse.cz Message-ID: <20130828093810.GA22849@rei.Home> References: <521C4688.9020305@cn.fujitsu.com> <521C46FB.7020308@cn.fujitsu.com> <20130827125144.GI10995@rei.Home> <521D710C.8030609@cn.fujitsu.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <521D710C.8030609@cn.fujitsu.com> Subject: Re: [LTP] [PATCH 2/2 v2] quotactl/quotactl02.c: create a case to test basic flags of quotactl(2) List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: DAN LI Cc: LTP list Hi! > > You don't need to have function to statically initialize a structure, I > > would just initialized it statically and passed right pointer to the > > testcase addr. > > I am afraid I don't catch your meaning. > > This function setup_setqlim set up the structure "dquota" for the setqlim test, > and crucially, the structure "dquota" is used by other tests, so its value will > change after statically initializing. > You can define as many structures as you want, one for this particular test and one for the rest of the testcases for example, does the syscall modify the structure? > > > >> + tst_mkfs(NULL, dev, "xfs", "-f"); > > > > I still think that the '-f' should go to the library instead. Or we can > > zero start of the device (where the filesystem superblock and signatures > > are, which should be first few bytes) before we call the mkfs. > > I vote to "add the -f parameter in the tst_mkfs() if fs_type is xfs" > Ok, I will fix that. -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list