Re: [LTP] RFC add _FORTIFY_SOURCE to default LTP CFLAGS

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1.1: Type: Text/Plain, Size: 1275 bytes --]

On Wednesday 28 August 2013 12:34:40 Mike Frysinger wrote:
> On Wednesday 28 August 2013 07:56:01 chrubis@suse.cz wrote:
> > > unfortunately that does not work.  this snippet from coreutils is
> > > probably better:
> > >   AH_VERBATIM([FORTIFY_SOURCE],
> > >   [/* Enable compile-time and run-time bounds-checking, and some
> > >   warnings,
> > >       without upsetting glibc 2.15+. */
> > >    #if !defined _FORTIFY_SOURCE && defined __OPTIMIZE__ && __OPTIMIZE__
> > >    # define _FORTIFY_SOURCE 2
> > >    #endif
> > >   ])
> > 
> > That wouldn't work here, as config.h is included only in a few testcases
> > (in these that actually use some of the defines there).
> > 
> > But given that this just copies some ifdefs into config.h what about
> > adding the snippet directly into compiler.h that is included from
> > test.h thus ends up in all testcases?
> 
> SGTM

err, no, that won't work either.  _FORTIFY_SOURCE must be defined before any 
header file is included.  otherwise, including all the C lib headers and then 
test.h and then defining this won't accomplish anything.

you could probably turn that AH_VERBATIM into a compile test and then add it 
to CPPFLAGS based on the result.  that would probably work in most cases.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 433 bytes --]

------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list