From: chrubis@suse.cz
To: Dave Kleikamp <dave.kleikamp@oracle.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] ltp: Fix races in mmap1
Date: Wed, 28 Aug 2013 16:33:56 +0200 [thread overview]
Message-ID: <20130828143355.GA383@rei> (raw)
In-Reply-To: <521DF60B.9010401@oracle.com>
Hi!
> static int verbose_print = 0;
> -static char *map_address;
> +static char *volatile map_address;
Ok.
> static jmp_buf jmpbuf;
> static volatile char read_lock = 0;
>
> @@ -228,11 +228,13 @@ void *read_mem(void *ptr)
> tst_resm(TINFO, "page fault occurred due to "
> "a read after an unmap");
> } else {
> - if (verbose_print)
> + if (verbose_print) {
> + read_lock = 1;
> tst_resm(TINFO,
> "read_mem(): content of memory: %s",
> (char *)map_address);
> -
> + read_lock = 0;
> + }
> for (j = 0; j < args[1]; j++) {
> read_lock = 1;
> if (map_address[j] != 'a')
Good catch, I've overlooked the tst_resm() when I was fixing the
testcase.
Commited, thanks.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2013-08-28 14:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 13:07 [LTP] [PATCH] ltp: Fix races in mmap1 Dave Kleikamp
2013-08-28 13:48 ` Stanislav Kholmanskikh
2013-08-28 14:33 ` chrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130828143355.GA383@rei \
--to=chrubis@suse.cz \
--cc=dave.kleikamp@oracle.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox