Re: [LTP] [PATCH 2/2] runltp: remove bashisms

[Anders Roxell <anders.roxell@linaro.org>]

Hi,

On 2013-08-29 10:41, Sedat Dilek wrote:
> On Thu, Aug 29, 2013 at 9:27 AM, Anders Roxell <anders.roxell@linaro.org> wrote:
> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> > ---
> >  runltp | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/runltp b/runltp
> > index a419bf8..970c4ee 100755
> > --- a/runltp
> > +++ b/runltp
> > @@ -733,15 +733,15 @@ main()
> >      #$PAN_COMMAND #Duplicated code here, because otherwise if we fail, only "PAN_COMMAND" gets output
> >
> >      ## Display the Output/Log/Failed/HTML file names here
> > -    echo -e "LOG File: \c"
> > +    echo -n "LOG File: "
> >      echo $LOGFILE | cut -b4-
> >
> >      if [ "$OUTPUTFILE" ]; then
> > -       echo -e "OUTPUT File: \c"
> > +       echo -n "OUTPUT File: "
> >         echo $OUTPUTFILE | cut -b4-
> >      fi
> >
> > -    echo -e "FAILED COMMAND File: \c"
> > +    echo -n "FAILED COMMAND File: "
> >      echo $FAILCMDFILE | cut -b4-
> >
> >      if [ "$HTMLFILE" ]; then
> > --
> > 1.8.1.2
> >
> 
> Yesterday, I looked through diverse GIT repos where I saw a commit
> saying that "echo" (dunno if it was "-e" or "-n") is not
> POSIX-compliant and "printf" should be used.
> I am no POSIX guy, but maybe someone can confirm this?
Thanks, I will rework and resend the patch.

/Anders

------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list