[LTP] [PATCH 0/2] Remove bashism and added required import

[LTP] [PATCH 0/2] Remove bashism and added required import

[Anders Roxell]

Hi,

Remove bashism and added required import

/Anders

Anders Roxell (2):
  realtime parser: remove unused and depricated imports
  runltp: remove bashisms

 runltp                               | 6 +++---
 testcases/realtime/scripts/parser.py | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

-- 
1.8.1.2


------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH 1/2] realtime parser: remove unused and depricated imports

[Anders Roxell]

Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
 testcases/realtime/scripts/parser.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testcases/realtime/scripts/parser.py b/testcases/realtime/scripts/parser.py
index b90233c..6b2dc73 100644
--- a/testcases/realtime/scripts/parser.py
+++ b/testcases/realtime/scripts/parser.py
@@ -26,7 +26,7 @@
 ##                                                                            ##
 ################################################################################
 
-import sys,os,string,re
+import sys
 
 class Log:
     def __init__(self,filename):
-- 
1.8.1.2


------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH 2/2] runltp: remove bashisms

[Anders Roxell]

Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
 runltp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/runltp b/runltp
index a419bf8..970c4ee 100755
--- a/runltp
+++ b/runltp
@@ -733,15 +733,15 @@ main()
     #$PAN_COMMAND #Duplicated code here, because otherwise if we fail, only "PAN_COMMAND" gets output
 
     ## Display the Output/Log/Failed/HTML file names here
-    echo -e "LOG File: \c"
+    echo -n "LOG File: "
     echo $LOGFILE | cut -b4-
 
     if [ "$OUTPUTFILE" ]; then
-       echo -e "OUTPUT File: \c"
+       echo -n "OUTPUT File: "
        echo $OUTPUTFILE | cut -b4-
     fi
 
-    echo -e "FAILED COMMAND File: \c"
+    echo -n "FAILED COMMAND File: "
     echo $FAILCMDFILE | cut -b4-
 
     if [ "$HTMLFILE" ]; then
-- 
1.8.1.2


------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 2/2] runltp: remove bashisms

[Sedat Dilek]

On Thu, Aug 29, 2013 at 9:27 AM, Anders Roxell <anders.roxell@linaro.org> wrote:
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
>  runltp | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/runltp b/runltp
> index a419bf8..970c4ee 100755
> --- a/runltp
> +++ b/runltp
> @@ -733,15 +733,15 @@ main()
>      #$PAN_COMMAND #Duplicated code here, because otherwise if we fail, only "PAN_COMMAND" gets output
>
>      ## Display the Output/Log/Failed/HTML file names here
> -    echo -e "LOG File: \c"
> +    echo -n "LOG File: "
>      echo $LOGFILE | cut -b4-
>
>      if [ "$OUTPUTFILE" ]; then
> -       echo -e "OUTPUT File: \c"
> +       echo -n "OUTPUT File: "
>         echo $OUTPUTFILE | cut -b4-
>      fi
>
> -    echo -e "FAILED COMMAND File: \c"
> +    echo -n "FAILED COMMAND File: "
>      echo $FAILCMDFILE | cut -b4-
>
>      if [ "$HTMLFILE" ]; then
> --
> 1.8.1.2
>

Yesterday, I looked through diverse GIT repos where I saw a commit
saying that "echo" (dunno if it was "-e" or "-n") is not
POSIX-compliant and "printf" should be used.
I am no POSIX guy, but maybe someone can confirm this?

- Sedat -

P.S.: Google gave me...

[1] http://pubs.opengroup.org/onlinepubs/009696799/utilities/echo.html
[2] https://bugs.kde.org/show_bug.cgi?id=160368

------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 2/2] runltp: remove bashisms

[Anders Roxell]

Hi,

On 2013-08-29 10:41, Sedat Dilek wrote:
> On Thu, Aug 29, 2013 at 9:27 AM, Anders Roxell <anders.roxell@linaro.org> wrote:
> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> > ---
> >  runltp | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/runltp b/runltp
> > index a419bf8..970c4ee 100755
> > --- a/runltp
> > +++ b/runltp
> > @@ -733,15 +733,15 @@ main()
> >      #$PAN_COMMAND #Duplicated code here, because otherwise if we fail, only "PAN_COMMAND" gets output
> >
> >      ## Display the Output/Log/Failed/HTML file names here
> > -    echo -e "LOG File: \c"
> > +    echo -n "LOG File: "
> >      echo $LOGFILE | cut -b4-
> >
> >      if [ "$OUTPUTFILE" ]; then
> > -       echo -e "OUTPUT File: \c"
> > +       echo -n "OUTPUT File: "
> >         echo $OUTPUTFILE | cut -b4-
> >      fi
> >
> > -    echo -e "FAILED COMMAND File: \c"
> > +    echo -n "FAILED COMMAND File: "
> >      echo $FAILCMDFILE | cut -b4-
> >
> >      if [ "$HTMLFILE" ]; then
> > --
> > 1.8.1.2
> >
> 
> Yesterday, I looked through diverse GIT repos where I saw a commit
> saying that "echo" (dunno if it was "-e" or "-n") is not
> POSIX-compliant and "printf" should be used.
> I am no POSIX guy, but maybe someone can confirm this?
Thanks, I will rework and resend the patch.

/Anders

------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 2/2] runltp: remove bashisms

[Mike Frysinger]

[-- Attachment #1.1: Type: Text/Plain, Size: 473 bytes --]

On Thursday 29 August 2013 04:41:33 Sedat Dilek wrote:
> On Thu, Aug 29, 2013 at 9:27 AM, Anders Roxell wrote:
> > -    echo -e "LOG File: \c"
> > +    echo -n "LOG File: "
> 
> Yesterday, I looked through diverse GIT repos where I saw a commit
> saying that "echo" (dunno if it was "-e" or "-n") is not
> POSIX-compliant and "printf" should be used.
> I am no POSIX guy, but maybe someone can confirm this?

use `printf` please for both -e and -n issues
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 433 bytes --]

------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 2/2] runltp: remove bashisms

[Anders Roxell]

Hi,

On 2013-08-29 20:16, Mike Frysinger wrote:
> On Thursday 29 August 2013 04:41:33 Sedat Dilek wrote:
> > On Thu, Aug 29, 2013 at 9:27 AM, Anders Roxell wrote:
> > > -    echo -e "LOG File: \c"
> > > +    echo -n "LOG File: "
> > 
> > Yesterday, I looked through diverse GIT repos where I saw a commit
> > saying that "echo" (dunno if it was "-e" or "-n") is not
> > POSIX-compliant and "printf" should be used.
> > I am no POSIX guy, but maybe someone can confirm this?
> 
> use `printf` please for both -e and -n issues
I did resend the patch yesterday, with subject: "[PATCHv2 0/2] Rework to
printf and added required import"

/Anders

------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list