* [LTP] [PATCH 0/2] Remove bashism and added required import @ 2013-08-29 7:27 Anders Roxell 2013-08-29 7:27 ` [LTP] [PATCH 1/2] realtime parser: remove unused and depricated imports Anders Roxell 2013-08-29 7:27 ` [LTP] [PATCH 2/2] runltp: remove bashisms Anders Roxell 0 siblings, 2 replies; 7+ messages in thread From: Anders Roxell @ 2013-08-29 7:27 UTC (permalink / raw) To: ltp-list; +Cc: patches Hi, Remove bashism and added required import /Anders Anders Roxell (2): realtime parser: remove unused and depricated imports runltp: remove bashisms runltp | 6 +++--- testcases/realtime/scripts/parser.py | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) -- 1.8.1.2 ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 7+ messages in thread
* [LTP] [PATCH 1/2] realtime parser: remove unused and depricated imports 2013-08-29 7:27 [LTP] [PATCH 0/2] Remove bashism and added required import Anders Roxell @ 2013-08-29 7:27 ` Anders Roxell 2013-08-29 7:27 ` [LTP] [PATCH 2/2] runltp: remove bashisms Anders Roxell 1 sibling, 0 replies; 7+ messages in thread From: Anders Roxell @ 2013-08-29 7:27 UTC (permalink / raw) To: ltp-list; +Cc: patches Signed-off-by: Anders Roxell <anders.roxell@linaro.org> --- testcases/realtime/scripts/parser.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testcases/realtime/scripts/parser.py b/testcases/realtime/scripts/parser.py index b90233c..6b2dc73 100644 --- a/testcases/realtime/scripts/parser.py +++ b/testcases/realtime/scripts/parser.py @@ -26,7 +26,7 @@ ## ## ################################################################################ -import sys,os,string,re +import sys class Log: def __init__(self,filename): -- 1.8.1.2 ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [LTP] [PATCH 2/2] runltp: remove bashisms 2013-08-29 7:27 [LTP] [PATCH 0/2] Remove bashism and added required import Anders Roxell 2013-08-29 7:27 ` [LTP] [PATCH 1/2] realtime parser: remove unused and depricated imports Anders Roxell @ 2013-08-29 7:27 ` Anders Roxell 2013-08-29 8:41 ` Sedat Dilek 1 sibling, 1 reply; 7+ messages in thread From: Anders Roxell @ 2013-08-29 7:27 UTC (permalink / raw) To: ltp-list; +Cc: patches Signed-off-by: Anders Roxell <anders.roxell@linaro.org> --- runltp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/runltp b/runltp index a419bf8..970c4ee 100755 --- a/runltp +++ b/runltp @@ -733,15 +733,15 @@ main() #$PAN_COMMAND #Duplicated code here, because otherwise if we fail, only "PAN_COMMAND" gets output ## Display the Output/Log/Failed/HTML file names here - echo -e "LOG File: \c" + echo -n "LOG File: " echo $LOGFILE | cut -b4- if [ "$OUTPUTFILE" ]; then - echo -e "OUTPUT File: \c" + echo -n "OUTPUT File: " echo $OUTPUTFILE | cut -b4- fi - echo -e "FAILED COMMAND File: \c" + echo -n "FAILED COMMAND File: " echo $FAILCMDFILE | cut -b4- if [ "$HTMLFILE" ]; then -- 1.8.1.2 ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [LTP] [PATCH 2/2] runltp: remove bashisms 2013-08-29 7:27 ` [LTP] [PATCH 2/2] runltp: remove bashisms Anders Roxell @ 2013-08-29 8:41 ` Sedat Dilek 2013-08-29 14:00 ` Anders Roxell 2013-08-30 0:16 ` Mike Frysinger 0 siblings, 2 replies; 7+ messages in thread From: Sedat Dilek @ 2013-08-29 8:41 UTC (permalink / raw) To: Anders Roxell; +Cc: ltp-list, patches On Thu, Aug 29, 2013 at 9:27 AM, Anders Roxell <anders.roxell@linaro.org> wrote: > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > --- > runltp | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/runltp b/runltp > index a419bf8..970c4ee 100755 > --- a/runltp > +++ b/runltp > @@ -733,15 +733,15 @@ main() > #$PAN_COMMAND #Duplicated code here, because otherwise if we fail, only "PAN_COMMAND" gets output > > ## Display the Output/Log/Failed/HTML file names here > - echo -e "LOG File: \c" > + echo -n "LOG File: " > echo $LOGFILE | cut -b4- > > if [ "$OUTPUTFILE" ]; then > - echo -e "OUTPUT File: \c" > + echo -n "OUTPUT File: " > echo $OUTPUTFILE | cut -b4- > fi > > - echo -e "FAILED COMMAND File: \c" > + echo -n "FAILED COMMAND File: " > echo $FAILCMDFILE | cut -b4- > > if [ "$HTMLFILE" ]; then > -- > 1.8.1.2 > Yesterday, I looked through diverse GIT repos where I saw a commit saying that "echo" (dunno if it was "-e" or "-n") is not POSIX-compliant and "printf" should be used. I am no POSIX guy, but maybe someone can confirm this? - Sedat - P.S.: Google gave me... [1] http://pubs.opengroup.org/onlinepubs/009696799/utilities/echo.html [2] https://bugs.kde.org/show_bug.cgi?id=160368 ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [PATCH 2/2] runltp: remove bashisms 2013-08-29 8:41 ` Sedat Dilek @ 2013-08-29 14:00 ` Anders Roxell 2013-08-30 0:16 ` Mike Frysinger 1 sibling, 0 replies; 7+ messages in thread From: Anders Roxell @ 2013-08-29 14:00 UTC (permalink / raw) To: Sedat Dilek; +Cc: ltp-list, patches Hi, On 2013-08-29 10:41, Sedat Dilek wrote: > On Thu, Aug 29, 2013 at 9:27 AM, Anders Roxell <anders.roxell@linaro.org> wrote: > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > > --- > > runltp | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/runltp b/runltp > > index a419bf8..970c4ee 100755 > > --- a/runltp > > +++ b/runltp > > @@ -733,15 +733,15 @@ main() > > #$PAN_COMMAND #Duplicated code here, because otherwise if we fail, only "PAN_COMMAND" gets output > > > > ## Display the Output/Log/Failed/HTML file names here > > - echo -e "LOG File: \c" > > + echo -n "LOG File: " > > echo $LOGFILE | cut -b4- > > > > if [ "$OUTPUTFILE" ]; then > > - echo -e "OUTPUT File: \c" > > + echo -n "OUTPUT File: " > > echo $OUTPUTFILE | cut -b4- > > fi > > > > - echo -e "FAILED COMMAND File: \c" > > + echo -n "FAILED COMMAND File: " > > echo $FAILCMDFILE | cut -b4- > > > > if [ "$HTMLFILE" ]; then > > -- > > 1.8.1.2 > > > > Yesterday, I looked through diverse GIT repos where I saw a commit > saying that "echo" (dunno if it was "-e" or "-n") is not > POSIX-compliant and "printf" should be used. > I am no POSIX guy, but maybe someone can confirm this? Thanks, I will rework and resend the patch. /Anders ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [PATCH 2/2] runltp: remove bashisms 2013-08-29 8:41 ` Sedat Dilek 2013-08-29 14:00 ` Anders Roxell @ 2013-08-30 0:16 ` Mike Frysinger 2013-08-30 6:22 ` Anders Roxell 1 sibling, 1 reply; 7+ messages in thread From: Mike Frysinger @ 2013-08-30 0:16 UTC (permalink / raw) To: ltp-list, sedat.dilek; +Cc: patches [-- Attachment #1.1: Type: Text/Plain, Size: 473 bytes --] On Thursday 29 August 2013 04:41:33 Sedat Dilek wrote: > On Thu, Aug 29, 2013 at 9:27 AM, Anders Roxell wrote: > > - echo -e "LOG File: \c" > > + echo -n "LOG File: " > > Yesterday, I looked through diverse GIT repos where I saw a commit > saying that "echo" (dunno if it was "-e" or "-n") is not > POSIX-compliant and "printf" should be used. > I am no POSIX guy, but maybe someone can confirm this? use `printf` please for both -e and -n issues -mike [-- Attachment #1.2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 836 bytes --] [-- Attachment #2: Type: text/plain, Size: 433 bytes --] ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk [-- Attachment #3: Type: text/plain, Size: 155 bytes --] _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [PATCH 2/2] runltp: remove bashisms 2013-08-30 0:16 ` Mike Frysinger @ 2013-08-30 6:22 ` Anders Roxell 0 siblings, 0 replies; 7+ messages in thread From: Anders Roxell @ 2013-08-30 6:22 UTC (permalink / raw) To: Mike Frysinger; +Cc: ltp-list, patches Hi, On 2013-08-29 20:16, Mike Frysinger wrote: > On Thursday 29 August 2013 04:41:33 Sedat Dilek wrote: > > On Thu, Aug 29, 2013 at 9:27 AM, Anders Roxell wrote: > > > - echo -e "LOG File: \c" > > > + echo -n "LOG File: " > > > > Yesterday, I looked through diverse GIT repos where I saw a commit > > saying that "echo" (dunno if it was "-e" or "-n") is not > > POSIX-compliant and "printf" should be used. > > I am no POSIX guy, but maybe someone can confirm this? > > use `printf` please for both -e and -n issues I did resend the patch yesterday, with subject: "[PATCHv2 0/2] Rework to printf and added required import" /Anders ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-08-30 6:18 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-08-29 7:27 [LTP] [PATCH 0/2] Remove bashism and added required import Anders Roxell 2013-08-29 7:27 ` [LTP] [PATCH 1/2] realtime parser: remove unused and depricated imports Anders Roxell 2013-08-29 7:27 ` [LTP] [PATCH 2/2] runltp: remove bashisms Anders Roxell 2013-08-29 8:41 ` Sedat Dilek 2013-08-29 14:00 ` Anders Roxell 2013-08-30 0:16 ` Mike Frysinger 2013-08-30 6:22 ` Anders Roxell
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox