Re: [LTP] [PATCH] device-drivers: acpi: update for Linux kernel 2.6.37+

[chrubis@suse.cz]

Hi!
> > Linux-2.6.37 is quite old, does it compile with Linux-3.10?
> >
> > Ideally it should work with broad range of kernels but that would likely
> > require great number of ifdefs...
> >
> >
> It works fine with 3.10..., 2.6.37 version is just starting point of the 
> range of kernels where it compiles.

That sounds good.

> > It would be better to convert this code to full LTP test so we can drop
> > the ltpapci.sh script.
> >
> > Also there doesn't seem to be any success/failure logic. It looks like
> > the program just opens the device and does some ioctls(). Do you have an
> > idea what is the purpose of this test?
> >
> I have only one intention of this patch - at least, make it compile and 
> run on the latest kernels, but subsequent patches can do the rest, e.g. 
> we can drop ltpacpi.sh, and make use of tst_module_* functions, also 
> return some general status of the acpi functions.

Ok. That is better than nothing. Still we need somebody to look into the
purpose of the test and what assertions it should make.

> It seems the test is checking ACPI kernel API... but I didn't get why 
> this test uses block device... and what is returning from 
> acpi_driver_data(). The test declares its own 'acpi_ec' structure and 
> trying to cast return pointer from acpi_driver_data() to it. But in the 
> kernel, this structure is slightly different (may be it wasn't in kernel 
> 2.6.27) and defined internally. That's why I've commented any use of 
> this structure in the test.
> 
> I'd appreciate any ideas.

Unfortunately I do not have any ideas here. I would try to contact the
original author and/or Linux ACPI maintainers, at least they should know
what to test and why (feel free to CC LTP ML).

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list