From: chrubis@suse.cz
To: alexey.kodanev@oracle.com
Cc: vasily.isaenko@oracle.com, ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] device-drivers: rtc: minor updates
Date: Mon, 9 Sep 2013 17:22:23 +0200 [thread overview]
Message-ID: <20130909152223.GA4586@rei> (raw)
In-Reply-To: <522DE321.5090701@oracle.com>
Hi!
> > Hi!
> >> Makefile updated.
> >> Added .gitignore file.
> >> Added root check and rtc device check.
> > The changes looks good, what about adding the test into kernel_misc
> > runtest file?
> >
> I thought I can do it in separate patches. We have to add device-drivers
> directory to .../testcases/kernel/Makefile and then include this test
> in .../device-drivers/Makefile to build it automatically.
> I've recently sent a patch which is adding Makefile to device-drivers
> directory, is it OK?
I would split it to patch that adds Makefile into device drivers
directory and adds device-drivers directory into the kernel/Makefile
(assuming that Makefile with empty SUBDIRS is noop) And for each fixed
test a patch that enables subdirectory once test is fixed along with
updating the runtest entry (which is a bit unfortunate as this may
generate collisions if you work on more than one subdir which means that
this patch should be done only once the test fix is acked). If you are
OK with that, let's start with rtc test.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2013-09-09 15:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 12:23 [LTP] [PATCH] device-drivers: rtc: minor updates Alexey Kodanev
2013-09-09 14:11 ` chrubis
[not found] ` <522DE321.5090701@oracle.com>
2013-09-09 15:22 ` chrubis [this message]
2013-09-10 12:47 ` chrubis
[not found] ` <522F2003.5010101@oracle.com>
2013-09-10 13:41 ` chrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130909152223.GA4586@rei \
--to=chrubis@suse.cz \
--cc=alexey.kodanev@oracle.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=vasily.isaenko@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox