[LTP] Policy regarding BASH

[LTP] Policy regarding BASH

[Stanislav Kholmanskikh]

Hi!

During looking into shell testcases I came across a situation where
* main shell script is a bash script (ie it has #!/bin/bash in the header)
* for each testcase number main shell script executes a separate (child) 
shell-script which has #!/bin/sh in the header

So If I try to run main script on Debian (where /bin/sh  points to 
/bin/dash) I get error like this:
root@debian7-x64:/opt/ltp/testcases/bin# ./run_cpuset_test.sh 3
TEST 3: CPUSET CONTROLLER TESTING
TEST STARTED: Please avoid using system while this test executes
./cpuset_exclusive_test.sh: 34: ./cpuset_funcs.sh: arithmetic 
expression: expecting primary: "N_NODES++"

So what is the policy regarding bash presence in LTP? Is it permitted to 
write testcases using bash specific features?
Or are we strongly encouraged to use "common shell" only?

And how should I proceed with this particular testcase? Try to remove 
"bashism" or just change header of child scripts from "#!/bin/sh" to 
"#!/bin/bash"?

Thank you.






------------------------------------------------------------------------------
LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99!
1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint
2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes
Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. 
http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] Policy regarding BASH

[Stanislav Kholmanskikh]

On 09/19/2013 04:47 PM, Stanislav Kholmanskikh wrote:
> Hi!
>
> During looking into shell testcases I came across a situation where
> * main shell script is a bash script (ie it has #!/bin/bash in the header)
> * for each testcase number main shell script executes a separate (child)
> shell-script which has #!/bin/sh in the header
>
> So If I try to run main script on Debian (where /bin/sh  points to
> /bin/dash) I get error like this:
> root@debian7-x64:/opt/ltp/testcases/bin# ./run_cpuset_test.sh 3
> TEST 3: CPUSET CONTROLLER TESTING
> TEST STARTED: Please avoid using system while this test executes
> ./cpuset_exclusive_test.sh: 34: ./cpuset_funcs.sh: arithmetic
> expression: expecting primary: "N_NODES++"
>
> So what is the policy regarding bash presence in LTP? Is it permitted to
> write testcases using bash specific features?
> Or are we strongly encouraged to use "common shell" only?
>
> And how should I proceed with this particular testcase? Try to remove
> "bashism" or just change header of child scripts from "#!/bin/sh" to
> "#!/bin/bash"?
>
> Thank you.
The problem is not because child is a "sh" script but because child 
includes cpuset_funcs.sh file (main includes it also) but
this file has bash-specific things.

>
>
>
>
>
> ------------------------------------------------------------------------------
> LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99!
> 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint
> 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes
> Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13.
> http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list


------------------------------------------------------------------------------
LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99!
1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint
2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes
Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. 
http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] Policy regarding BASH

[chrubis]

Hi!
> So what is the policy regarding bash presence in LTP? Is it permitted to 
> write testcases using bash specific features?
> Or are we strongly encouraged to use "common shell" only?

Just fix the tests to work with common shell and send a patch.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99!
1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint
2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes
Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. 
http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] Policy regarding BASH

[Mike Frysinger]

[-- Attachment #1.1: Type: Text/Plain, Size: 432 bytes --]

On Thursday 19 September 2013 09:40:50 chrubis@suse.cz wrote:
> > So what is the policy regarding bash presence in LTP? Is it permitted to
> > write testcases using bash specific features?
> > Or are we strongly encouraged to use "common shell" only?
> 
> Just fix the tests to work with common shell and send a patch.

and please do not do it blindly.  running `checkbashisms` is known to produce 
false positives.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 416 bytes --]

------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list