From: chrubis@suse.cz
To: Alexey Kodanev <alexey.kodanev@oracle.com>
Cc: vasily.isaenko@oracle.com, ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH v5 2/2] device-drivers: block: fixes
Date: Wed, 2 Oct 2013 12:41:14 +0200 [thread overview]
Message-ID: <20131002104114.GA16429@rei> (raw)
In-Reply-To: <1380705830-7628-1-git-send-email-alexey.kodanev@oracle.com>
Hi!
> Fixed test-cases behavior: major number greater than 255 is valid,
> empty device name is valid.
> Added test-cases results and sysfs files.
> Added user-space program which checks each test-case result.
> Added command line parameter 'a': run all test-cases.
...
> + if (major2 == 0)
> + unregister_blkdev(major, BLK_DEV_NAME);
> + else {
> + pass = 0;
> + prk_debug("1st call to register_blkdev() with major=%i "
> + "failed with error %i\n", major, major2);
> + }
Pushed with two more curly braces around this block, thanks.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2013-10-02 10:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 9:23 [LTP] [PATCH v5 2/2] device-drivers: block: fixes Alexey Kodanev
2013-10-02 10:41 ` chrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131002104114.GA16429@rei \
--to=chrubis@suse.cz \
--cc=alexey.kodanev@oracle.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=vasily.isaenko@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox