Re: [LTP] [PATCH 2/2] device-drivers: pci: fixes

[chrubis@suse.cz]

Hi!
> > So the while cycle runs for all pci devices? How does this works?
> >
> > It seems to run all tests then increment pci_device until test number
> > zero fails. This needs to cleaned up so that the codeflow is less
> > cryptic. Or at least deserves a comment what is done and why.
> >
> Yes, my intention was to perform all test-cases with all available 
> pci-devices, not just with the first found. This behavior managed by 
> user-space test, so may be add a cmd-line option like test all or first 
> found pci-device(s)?

No need for that. What I do not like on the test is that there is no
correspondence between the pci device number in the userspace and in the
test module, i.e. the pci_number is incremented automagically in the
module once all tests are executed. This is hard to figure out. It would
be better if we had explicit mechanism for that, for example sysfs file
you write the number to (and get -EINVAL if the number is out of range).

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list