From: chrubis@suse.cz
To: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
Cc: vasily.isaenko@oracle.com, ltp-list@lists.sourceforge.net
Subject: Re: [LTP] msgctl11: changed logic
Date: Wed, 16 Oct 2013 16:18:10 +0200 [thread overview]
Message-ID: <20131016141810.GA28545@rei> (raw)
In-Reply-To: <1381914358-29029-1-git-send-email-stanislav.kholmanskikh@oracle.com>
Hi!
> I've not verified this patch with UCLINUX defined. Yet.
>
> Just want to be sure that the general idea is acceptable.
The idea is fine, but the original test is so messed up I would be
tempted to rewrite it from scratch...
If you decide to fix it (which is also a good idea ;), please clean it
up first (in separate patch).
Moreovere the code for msgctl09 is nearly the same. What about moving
the commont parts into a header in the cleanup process?
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2013-10-16 14:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 9:05 [LTP] msgctl11: changed logic Stanislav Kholmanskikh
2013-10-16 9:05 ` [LTP] [PATCH] " Stanislav Kholmanskikh
2013-10-16 14:21 ` chrubis
2013-10-16 14:18 ` chrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131016141810.GA28545@rei \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=stanislav.kholmanskikh@oracle.com \
--cc=vasily.isaenko@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox