From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1VWRvh-000303-1Y for ltp-list@lists.sourceforge.net; Wed, 16 Oct 2013 14:18:29 +0000 Date: Wed, 16 Oct 2013 16:18:10 +0200 From: chrubis@suse.cz Message-ID: <20131016141810.GA28545@rei> References: <1381914358-29029-1-git-send-email-stanislav.kholmanskikh@oracle.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1381914358-29029-1-git-send-email-stanislav.kholmanskikh@oracle.com> Subject: Re: [LTP] msgctl11: changed logic List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: Stanislav Kholmanskikh Cc: vasily.isaenko@oracle.com, ltp-list@lists.sourceforge.net Hi! > I've not verified this patch with UCLINUX defined. Yet. > > Just want to be sure that the general idea is acceptable. The idea is fine, but the original test is so messed up I would be tempted to rewrite it from scratch... If you decide to fix it (which is also a good idea ;), please clean it up first (in separate patch). Moreovere the code for msgctl09 is nearly the same. What about moving the commont parts into a header in the cleanup process? -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list