From: chrubis@suse.cz
To: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] access/access06.c: add ELOOP, ENOTDIR, EROFS error number test for access(2)
Date: Thu, 17 Oct 2013 14:44:55 +0200 [thread overview]
Message-ID: <20131017124455.GB24992@rei> (raw)
In-Reply-To: <525F5E68.7030108@cn.fujitsu.com>
Hi!
> > Also looking at the access testcases, there is allready access05 to test
> > access failures, I wonder if it would be better to move the ENOTDIR and
> > ELOOP tests there (after it's cleaned up a bit). But I'm not sure about
> > this myself...
>
> Since access03 and access05 both contain error number tests for access,
> I think a new access06 would be better to make the three error number
> tests clearer.
> If you perfer to add these test to existing tests, I will make a new version
> patch.
Actually after looking at your v2 patch the code is cleaner than the
access05.c, what about moving the testcases from access05 to the test
you written and calling the result access05? Are you OK with that?
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2013-10-17 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 9:18 [LTP] [PATCH] access/access06.c: add ELOOP, ENOTDIR, EROFS error number test for access(2) Wang xiaoguang
2013-10-15 11:54 ` chrubis
[not found] ` <525F5E68.7030108@cn.fujitsu.com>
2013-10-17 12:44 ` chrubis [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-10-15 9:32 Wang xiaoguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131017124455.GB24992@rei \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=wangxg.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox