public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: chrubis@suse.cz
To: Liao Guoqi-B25230 <B25230@freescale.com>
Cc: "ltp-list@lists.sourceforge.net" <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] "cpu_hotplug/functional/cpuhotplug05.sh" failed
Date: Thu, 17 Oct 2013 14:52:33 +0200	[thread overview]
Message-ID: <20131017125233.GC24992@rei> (raw)
In-Reply-To: <9C261B4871671149A8D67C0E659573915077DF@039-SN1MPN1-003.039d.mgd.msft.net>

Hi!
> ---
>  .../hotplug/cpu_hotplug/functional/cpuhotplug05.sh |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh
> index e64b91c..e893f04 100755
> --- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh
> +++ b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh
> @@ -57,8 +57,8 @@ until [ $TST_COUNT -gt $TST_TOTAL ]; do
>         sleep 2
>         SAR_PID=$!
> 
> -       # Verify that SAR has correctly listed the missing CPU as 'nan'
> -       while ! grep -iq nan $TMP/log_$$; do
> +       # Verify that SAR has correctly listed the missing CPU
> +       while ! awk '{print $8}' $TMP/log_$$|grep -i "^0.00"; do
>                 tst_resm TFAIL "CPU${CPU_TO_TEST} Not Found on SAR!"
>                 exit_clean 1
>         done
> @@ -66,7 +66,7 @@ until [ $TST_COUNT -gt $TST_TOTAL ]; do
>         sleep .5
> 
>         # Verify that at least some of the CPUs are offline
> -       NUMBER_CPU_OFF=$(grep "$time" $TMP/log_$$ | grep -i nan | wc -l)
> +        NUMBER_CPU_OFF=$(grep "$time" $TMP/log_$$ | awk '{print $8}' |grep -i "^0.00" | wc -l)
>         if [ ${NUMBER_CPU_OFF} -eq 0 ]; then
>                 tst_resm TBROK "no CPUs found offline"
>                 exit_clean 1
> @@ -83,7 +83,7 @@ until [ $TST_COUNT -gt $TST_TOTAL ]; do
>         sleep .5
> 
>         # Check that SAR registered the change in CPU online/offline states
> -       NEW_NUMBER_CPU_OFF=$(grep "$time" $TMP/log_$$ | grep -i nan | wc -l)
> +        NEW_NUMBER_CPU_OFF=$(grep "$time" $TMP/log_$$|awk '{print $8}'|grep -i "^0.00"| wc -l)
>         : $(( NUMBER_CPU_OFF -= 1 ))
>         if [ "$NUMBER_CPU_OFF" = "$NEW_NUMBER_CPU_OFF" ]; then
>                 tst_resm TPASS "CPU was found after turned on."

Ok, that fixes it for sar that does not print nan. Do you have an idea
for how long the sar behaves this way?

Because I do not wan't to break the test for anybody with slightly older
sasstat package.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  parent reply	other threads:[~2013-10-17 12:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-16  5:29 [LTP] "cpu_hotplug/functional/cpuhotplug05.sh" failed Liao Guoqi-B25230
2013-10-16 11:22 ` chrubis
     [not found]   ` <9C261B4871671149A8D67C0E659573915077DF@039-SN1MPN1-003.039d.mgd.msft.net>
2013-10-17 12:52     ` chrubis [this message]
     [not found]       ` <9C261B4871671149A8D67C0E65957391507F9C@039-SN1MPN1-003.039d.mgd.msft.net>
2013-10-21 11:15         ` chrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131017125233.GC24992@rei \
    --to=chrubis@suse.cz \
    --cc=B25230@freescale.com \
    --cc=ltp-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox