[LTP] [PATCH] memcg_control: revert memory.use_hierarchy value to 0

[LTP] [PATCH] memcg_control: revert memory.use_hierarchy value to 0

[Stanislav Kholmanskikh]

Documentation/cgroups/memory.txt states that "Enabling/disabling will
fail if either the cgroup already has other cgroups created below it,
or if the parent cgroup has use_hierarchy enabled."

memcg_control_test.sh sets global memory.use_hierarchy value to 1 before
the execution of its own tests but doesn't revert it back to 0 after
they complete.

It causes failures of memcg_stat_test.sh and memcg_use_hierarchy_test.sh
testcases if runtest/controllers is run twice on the same host.

Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
---
 .../memcg/control/memcg_control_test.sh            |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/testcases/kernel/controllers/memcg/control/memcg_control_test.sh b/testcases/kernel/controllers/memcg/control/memcg_control_test.sh
index dfc1302..fa50516 100644
--- a/testcases/kernel/controllers/memcg/control/memcg_control_test.sh
+++ b/testcases/kernel/controllers/memcg/control/memcg_control_test.sh
@@ -146,6 +146,8 @@ while [ $TST_NUM -le $TST_TOTAL ]; do
 	: $((TST_NUM += 1))
 done
 
+echo 0 > mnt/memory.use_hierarchy 2> /dev/null
+
 cleanup
 
 if [ "$FAILED_CNT" -ne 0 ]; then
-- 
1.7.1


------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] memcg_control: revert memory.use_hierarchy value to 0

[chrubis]

Hi!
> Documentation/cgroups/memory.txt states that "Enabling/disabling will
> fail if either the cgroup already has other cgroups created below it,
> or if the parent cgroup has use_hierarchy enabled."
> 
> memcg_control_test.sh sets global memory.use_hierarchy value to 1 before
> the execution of its own tests but doesn't revert it back to 0 after
> they complete.
> 
> It causes failures of memcg_stat_test.sh and memcg_use_hierarchy_test.sh
> testcases if runtest/controllers is run twice on the same host.
> 
> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>

Pushed, thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list