Re: [LTP] [PATCH] msgctl{08, 09, 10, 11}: cleanup

[chrubis@suse.cz]

Hi!
> diff --git a/testcases/kernel/syscalls/ipc/msgctl/Makefile b/testcases/kernel/syscalls/ipc/msgctl/Makefile
> index f467389..ae61b51 100644
> --- a/testcases/kernel/syscalls/ipc/msgctl/Makefile
> +++ b/testcases/kernel/syscalls/ipc/msgctl/Makefile
> @@ -18,6 +18,15 @@
>  
>  top_srcdir              ?= ../../../../..
>  
> +FILTER_OUT_MAKE_TARGETS	:= libmsgctl
> +
>  include $(top_srcdir)/include/mk/testcases.mk
>  include $(abs_srcdir)/../Makefile.inc
>  include $(top_srcdir)/include/mk/generic_leaf_target.mk
> +
> +SRCS			?= $(wildcard $(abs_srcdir)/*.c)
> +OBJS			:= $(notdir $(patsubst %.c,%.o,$(SRCS)))
> +.INTERMEDIATE: $(OBJS)
> +
> +$(MAKE_TARGETS): %: %.o libmsgctl.o
> +libmsgctl.o: libmsgctl.h
> diff --git a/testcases/kernel/syscalls/ipc/msgctl/libmsgctl.c b/testcases/kernel/syscalls/ipc/msgctl/libmsgctl.c
> new file mode 100644
> index 0000000..fa77b56

This is too hacky what about building .a library instead as it's done in
testcases/kernel/mem/lib ?

I've looked into the lib.mk and it looks like you don't even have to put
the lib in the separate directory if you set LIBSRC in the corresponding
Makefile.

I should really make some time to write more documentation for the most
common build system usages....

> diff --git a/testcases/kernel/syscalls/ipc/msgctl/msgctl08.c b/testcases/kernel/syscalls/ipc/msgctl/msgctl08.c
> index f733946..8d7e431 100644
> --- a/testcases/kernel/syscalls/ipc/msgctl/msgctl08.c
> +++ b/testcases/kernel/syscalls/ipc/msgctl/msgctl08.c
> @@ -51,6 +51,7 @@
>  #include "test.h"
>  #include "usctest.h"
>  #include "ipcmsg.h"
> +#include "libmsgctl.h"
>  
>  void setup();
>  void cleanup();

Can you add void to all functions that take no parameters? (Otherwise
the compiler thinks that they take unspecified number of integer
parameters...)

> @@ -61,38 +62,22 @@ void cleanup();
>  char *TCID = "msgctl08";	/* Test program identifier.    */
>  int TST_TOTAL = 1;		/* Total number of test cases. */

Can you please also remove useless comments as:

/* Test program identifier.    */

/* Total number of test cases. */

/*
 *  *  *  * These globals must be defined in the test.
  *   *   *   */

/*--------------------------------------------------------------------*/

And similar?


-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list