From: chrubis@suse.cz
To: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
Cc: vasily.isaenko@oracle.com, ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH V2 1/2] Implemented SAFE_TOUCH macro
Date: Wed, 6 Nov 2013 12:03:39 +0100 [thread overview]
Message-ID: <20131106110338.GA28367@rei> (raw)
In-Reply-To: <1383726187-25943-1-git-send-email-stanislav.kholmanskikh@oracle.com>
Hi!
> + ret = open(pathname, O_CREAT | O_WRONLY, defmode);
> + if (ret == -1)
> + tst_brkm(TBROK | TERRNO, cleanup_fn,
> + "Failed to open file '%s' at %s:%d",
> + pathname, file, lineno);
I (and LKML coding style) prefer to have curly braces around multiline
blocks, but that is very minor...
Pushed, thanks.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
November Webinars for C, C++, Fortran Developers
Accelerate application performance with scalable programming models. Explore
techniques for threading, error checking, porting, and tuning. Get the most
from the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2013-11-06 11:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 5:57 [LTP] [PATCH] prot_hsymlinks: explicitly close file descriptors Stanislav Kholmanskikh
2013-11-04 15:26 ` chrubis
[not found] ` <5278CF8E.7020104@oracle.com>
2013-11-05 16:46 ` chrubis
2013-11-06 8:23 ` [LTP] [PATCH V2 1/2] Implemented SAFE_TOUCH macro Stanislav Kholmanskikh
2013-11-06 11:03 ` chrubis [this message]
2013-11-06 8:23 ` [LTP] [PATCH V2 2/2] prot_hsymlinks: use SAFE_TOUCH Stanislav Kholmanskikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131106110338.GA28367@rei \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=stanislav.kholmanskikh@oracle.com \
--cc=vasily.isaenko@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox