From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1Ve0u0-0002Fi-Tc for ltp-list@lists.sourceforge.net; Wed, 06 Nov 2013 11:04:00 +0000 Date: Wed, 6 Nov 2013 12:03:39 +0100 From: chrubis@suse.cz Message-ID: <20131106110338.GA28367@rei> References: <20131105164645.GB21812@rei.suse.cz> <1383726187-25943-1-git-send-email-stanislav.kholmanskikh@oracle.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1383726187-25943-1-git-send-email-stanislav.kholmanskikh@oracle.com> Subject: Re: [LTP] [PATCH V2 1/2] Implemented SAFE_TOUCH macro List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: Stanislav Kholmanskikh Cc: vasily.isaenko@oracle.com, ltp-list@lists.sourceforge.net Hi! > + ret = open(pathname, O_CREAT | O_WRONLY, defmode); > + if (ret == -1) > + tst_brkm(TBROK | TERRNO, cleanup_fn, > + "Failed to open file '%s' at %s:%d", > + pathname, file, lineno); I (and LKML coding style) prefer to have curly braces around multiline blocks, but that is very minor... Pushed, thanks. -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list