Re: [LTP] [PATCH] clock_getres/clock_getres01.c: cleanup

[chrubis@suse.cz]

Hi!
> Fix the messy testcase of clock_getres01.c
> 
> Signed-off-by: Zeng Linggang <zenglg.jy@cn.fujitsu.com>

That's better that the previous state but there are still some things to
fix:

1. The options are unused (opt_debug is only set and never used)
   we can strip all the custom option parsing and remove the usage()
   function and add LTP standard:

        char *msg;

        if ((msg = parse_opts(ac, av, NULL, NULL)) != NULL)
                tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);


2. Does the test really need to create temporary directory?
   It does not seem to create any files, so we can remove the
   tst_tmpdir() and tst_rmdir() in cleanup() and setup().

Also I would sanitize the comments in test header so that the ending */ does
not overflow 80 chars and end up on the same column. (May need to move the word Foundation to the previous line)

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
November Webinars for C, C++, Fortran Developers
Accelerate application performance with scalable programming models. Explore
techniques for threading, error checking, porting, and tuning. Get the most 
from the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list