From: chrubis@suse.cz
To: Simon Xu <xu.simon@oracle.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] networktests.sh: add ${LTPROOT}/bin into $PATH
Date: Thu, 7 Nov 2013 17:07:50 +0100 [thread overview]
Message-ID: <20131107160750.GA9653@rei.Home> (raw)
In-Reply-To: <1383556829-1464-1-git-send-email-xu.simon@oracle.com>
Hi!
> Some tests need `gethost' (e.g. sendfile01), which lives in ${LTPROOT}/bin,
> which is not in $PATH of networktests.sh.
>
> Signed-off-by: Simon Xu <xu.simon@oracle.com>
> ---
> testscripts/networktests.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/testscripts/networktests.sh b/testscripts/networktests.sh
> index b136749..9465356 100755
> --- a/testscripts/networktests.sh
> +++ b/testscripts/networktests.sh
> @@ -110,7 +110,7 @@ fi
>
> cd $TMPDIR
>
> -export PATH="${PATH}:${LTPROOT}/testcases/bin"
> +export PATH="${PATH}:${LTPROOT}/bin:${LTPROOT}/testcases/bin"
You can remove the original export that adds ${LTPROOT}/testcases/bin as
this path is allready added by runltp script.
And I think that better solution would be to install genhost into the
testcases/bin (as the rest of the binaries used from the tests such as
tst_resm).
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
November Webinars for C, C++, Fortran Developers
Accelerate application performance with scalable programming models. Explore
techniques for threading, error checking, porting, and tuning. Get the most
from the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2013-11-07 16:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 9:20 [LTP] [PATCH] networktests.sh: add ${LTPROOT}/bin into $PATH Simon Xu
2013-11-07 16:07 ` chrubis [this message]
[not found] ` <527C5B3D.60205@oracle.com>
2013-11-11 14:08 ` chrubis
2013-11-12 10:59 ` [LTP] [PATCH] move gethost from tools to sendfile01 Simon Xu
2013-11-12 12:38 ` chrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131107160750.GA9653@rei.Home \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=xu.simon@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox