From: chrubis@suse.cz
To: Simon Xu <xu.simon@oracle.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] sendfile: add SF_Server into INSTALL_TARGETS in Makefile
Date: Thu, 7 Nov 2013 17:19:51 +0100 [thread overview]
Message-ID: <20131107161950.GC9653@rei.Home> (raw)
In-Reply-To: <1383719585-692-1-git-send-email-xu.simon@oracle.com>
Hi!
> sendfile01 always fails because SF_Server file is not installed.
>
> Signed-off-by: Simon Xu <xu.simon@oracle.com>
> ---
> testcases/network/tcp_cmds/sendfile/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/testcases/network/tcp_cmds/sendfile/Makefile b/testcases/network/tcp_cmds/sendfile/Makefile
> index 124ce5d..17a985a 100644
> --- a/testcases/network/tcp_cmds/sendfile/Makefile
> +++ b/testcases/network/tcp_cmds/sendfile/Makefile
> @@ -27,7 +27,7 @@ include $(abs_srcdir)/../Makefile.inc
>
> CPPFLAGS += -I$(abs_srcdir)/../include
>
> -INSTALL_TARGETS := sendfile01
> +INSTALL_TARGETS := sendfile01 SF_Server
Good catch, but can you please rename the file to sendfile01_server and
fix the execution accordingly before it gets applied?
Note that all the test binaries are installed into one directory which
makes it harder to avoid collisions and figure out what belongs to
what...
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
November Webinars for C, C++, Fortran Developers
Accelerate application performance with scalable programming models. Explore
techniques for threading, error checking, porting, and tuning. Get the most
from the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2013-11-07 16:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 6:33 [LTP] [PATCH] sendfile: add SF_Server into INSTALL_TARGETS in Makefile Simon Xu
2013-11-07 16:19 ` chrubis [this message]
2013-11-08 2:47 ` [LTP] [PATCH] sendfile01: rename SF_Server to sendfile01_server and add it into Makefile Simon Xu
2013-11-11 17:04 ` chrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131107161950.GC9653@rei.Home \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=xu.simon@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox