public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: chrubis@suse.cz
To: Simon Xu <xu.simon@oracle.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH V2] rpc01: fix $TCbin and $TCtmp and data file names
Date: Thu, 7 Nov 2013 17:25:02 +0100	[thread overview]
Message-ID: <20131107162501.GD9653@rei.Home> (raw)
In-Reply-To: <1383715718-507-1-git-send-email-xu.simon@oracle.com>

Hi!
> The values of TCbin and TCtmp should be swapped, and `rpc1' is in TCbin,
> not TCtmp.  Also correct the file names 'file.1' and 'file.2' which do not
> exist.
> 
> Signed-off-by: Simon Xu <xu.simon@oracle.com>
> ---
>  testcases/network/rpc/basic_tests/rpc01/rpc01 | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/testcases/network/rpc/basic_tests/rpc01/rpc01 b/testcases/network/rpc/basic_tests/rpc01/rpc01
> index ef97a95..8594835 100755
> --- a/testcases/network/rpc/basic_tests/rpc01/rpc01
> +++ b/testcases/network/rpc/basic_tests/rpc01/rpc01
> @@ -36,13 +36,13 @@
>  $trace_logic
>  this_file=${0##*/}
>  TC=${TC:=rpc01}
> -TCbin=${TCbin:=`pwd`}
> +TCbin=${TCbin:=$LTPROOT/testcases/bin}
>  TCdat=${TCdat:=$TCbin/datafiles}
> -TCtmp=${TCtmp:=$LTPROOT/testcases/bin}
> +TCtmp=${TCtmp:=`pwd`}
>  NUMLOOPS=${NUMLOOPS:=3}
>  RHOST=${RHOST:=`hostname`}
>  CLEANUP=${CLEANUP:="ON"}
> -DATAFILES=${DATAFILES:="file.1 file.2"}
> +DATAFILES=${DATAFILES:="bin.med bin.sm"}
>  
>  #=============================================================================
>  # FUNCTION NAME:        do_test
> @@ -68,7 +68,7 @@ do_test()
>      do
>        for FILE in $DATAFILES
>        do
> -	$TCtmp/rpc1 -s $RHOST -f $TCdat/$FILE
> +	$TCbin/rpc1 -s $RHOST -f $TCdat/$FILE

The runltp script adds $LTPROOT/testcases/bin to path so you should
reduce this only to rpc1 and it should work.

The runltp script also sets $TMPDIR as temporary directory.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
November Webinars for C, C++, Fortran Developers
Accelerate application performance with scalable programming models. Explore
techniques for threading, error checking, porting, and tuning. Get the most 
from the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2013-11-07 16:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-06  2:25 [LTP] [PATCH] rpc01: fix $TCbin and $TCtmp Simon Xu
2013-11-06  5:28 ` [LTP] [PATCH V2] rpc01: fix $TCbin and $TCtmp and data file names Simon Xu
2013-11-07 16:25   ` chrubis [this message]
     [not found]     ` <527C45FD.3090008@oracle.com>
2013-11-11 14:15       ` chrubis
2013-11-19  6:14         ` [LTP] [PATCH V4] rpc01: fix paths and add Makefile for datafiles Simon Xu
2013-11-25 13:39           ` Simon Xu
2013-11-26 14:49           ` chrubis
     [not found]             ` <52955FA1.7020909@oracle.com>
2013-11-27 11:49               ` chrubis
     [not found]                 ` <52971586.5090009@oracle.com>
2013-11-28 10:10                   ` [LTP] [PATCH V5] " Simon Xu
2013-12-02 17:59                     ` chrubis
2013-11-28 10:20                   ` [LTP] [PATCH V4] " chrubis
2013-11-08  6:17   ` [LTP] [PATCH V3] rpc01: fix $TCbin and $TCtmp " Simon Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131107162501.GD9653@rei.Home \
    --to=chrubis@suse.cz \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=xu.simon@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox