From: chrubis@suse.cz
To: Simon Xu <xu.simon@oracle.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH V2] xinetd_tests.sh: remove RECORD and eliminate "|| RC=$?"
Date: Mon, 11 Nov 2013 18:06:01 +0100 [thread overview]
Message-ID: <20131111170600.GD12940@rei.Home> (raw)
In-Reply-To: <1383880727-723-1-git-send-email-xu.simon@oracle.com>
Hi!
> 1) In xinetd.conf, `RECORD' is not a valid value for entry `log_on_failure'
> (I couldn't find a distro in which it's valid), and it makes xinetd
> successfully starts and promptly exit with error message:
>
> "Bad log_on_failure flag: RECORD [file=/etc/xinetd.conf] [line=6]",
>
> but the test will pass because telnet service is not started and that's
> what it expect.
>
> 2) Eliminate '|| RC=$?' because because it may not be excecuted and the
> original value in RC can mess things up. Also remove the RC=0
> initializations that are now unnecessary.
>
> Signed-off-by: Simon Xu <xu.simon@oracle.com>
Pushed, thanks.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
November Webinars for C, C++, Fortran Developers
Accelerate application performance with scalable programming models. Explore
techniques for threading, error checking, porting, and tuning. Get the most
from the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2013-11-11 17:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 10:01 [LTP] [PATCH] xinetd_tests.sh: remove RECORD and eliminate "|| RC=$?" Simon Xu
2013-11-07 16:14 ` chrubis
2013-11-08 3:18 ` [LTP] [PATCH V2] " Simon Xu
2013-11-11 17:06 ` chrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131111170600.GD12940@rei.Home \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=xu.simon@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox